Skip to content

Use docker-compose shipped in GHA runners#4184

Merged
aldy505 merged 1 commit intogetsentry:masterfrom
aminvakil:use_compose_from_gha
Feb 19, 2026
Merged

Use docker-compose shipped in GHA runners#4184
aldy505 merged 1 commit intogetsentry:masterfrom
aminvakil:use_compose_from_gha

Conversation

@aminvakil
Copy link
Collaborator

Continuation of #4179 (review) .

docker-compose has been stabilized for a while without breaking changes in main commands, I guess we can use whatever docker-compose version which GHA runners ship.

Also as it has been more than two years docker-ce package (in linux environments at least) is dependent on docker-compose-plugin, therefore upgrading docker-compose-plugin has been a lot easier for users.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@github-actions
Copy link

github-actions bot commented Feb 19, 2026

Changelog Preview

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


Bug Fixes 🐛

  • Prevent script injection vulnerability in get-compose-action by fix-it-felix-sentry in #4179

Other

  • Use docker-compose shipped in GHA runners by aminvakil in #4184

🤖 This preview updates automatically when you update the PR.

@aminvakil aminvakil force-pushed the use_compose_from_gha branch from d24eb11 to 173acd7 Compare February 19, 2026 09:55
@aminvakil
Copy link
Collaborator Author

Current versions are:
arm64:

  Found docker version 28.0.4
  Found docker Compose version 2.38.2

amd64:

  Found docker version 29.1.5
  Found docker Compose version 2.40.3

I use docker-compose v5.0.2 locally and it's fine as well.

@aldy505
Copy link
Collaborator

aldy505 commented Feb 19, 2026

The version mismatch is interesting.

@aldy505 aldy505 merged commit 29dac97 into getsentry:master Feb 19, 2026
12 checks passed
@aminvakil aminvakil deleted the use_compose_from_gha branch February 19, 2026 16:12
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants