Skip to content

fix(test): Add Authority Key Identifier to SSL certificates#4162

Merged
aldy505 merged 1 commit intomasterfrom
fix/ssl-cert-authority-key-identifier
Feb 5, 2026
Merged

fix(test): Add Authority Key Identifier to SSL certificates#4162
aldy505 merged 1 commit intomasterfrom
fix/ssl-cert-authority-key-identifier

Conversation

@oioki
Copy link
Member

@oioki oioki commented Feb 5, 2026 •
edited
Loading

Fixes test_custom_certificate_authorities test failure after urllib3 2.6.3 bump.

urllib3 2.6.x enforces stricter X.509 validation requiring proper SubjectKeyIdentifier and AuthorityKeyIdentifier extensions per RFC 5280.

Key changes:

.add_extension(
    x509.SubjectKeyIdentifier.from_public_key(ca_key.public_key()),
    critical=False,
)
.add_extension(
    x509.AuthorityKeyIdentifier.from_issuer_subject_key_identifier(
        ca_cert.extensions.get_extension_for_class(x509.SubjectKeyIdentifier).value
    ),
    critical=False,
)

@oioki @claude
fix(test): Add Authority Key Identifier to SSL certificates
304e121 
Fixes test_custom_certificate_authorities test failure after urllib3 2.6.3
bump. urllib3 2.6.x enforces stricter X.509 validation requiring proper
SubjectKeyIdentifier and AuthorityKeyIdentifier extensions per RFC 5280.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@github-actions
Copy link

github-actions bot commented Feb 5, 2026 •
edited
Loading

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).

Bug Fixes 🐛

  • (test) Add Authority Key Identifier to SSL certificates by oioki in #4162

Internal Changes 🔧

Deps

  • Bump getsentry/action-release from 3.4.0 to 3.5.0 by dependabot in #4133
  • Bump actions/checkout from 6.0.0 to 6.0.2 by dependabot in #4155
  • Bump actions/setup-python from 6.1.0 to 6.2.0 by dependabot in #4154
  • Bump getsentry/craft from 2.19.0 to 2.20.1 by dependabot in #4152
  • Bump actions/setup-node from 6.1.0 to 6.2.0 by dependabot in #4153
  • Bump astral-sh/setup-uv from 7.1.6 to 7.2.0 by dependabot in #4132
  • Bump codecov/test-results-action from 1.1.1 to 1.2.1 by dependabot in #4115
  • Bump codecov/codecov-action from 5.5.1 to 5.5.2 by dependabot in #4102
  • Bump urllib3 from 2.5.0 to 2.6.3 by dependabot in #4150

Other

  • Fix changelog-preview for external contributors by BYK in #4158

Other

  • Allow configuring Sentry taskworker concurrency via env by madest92 in #4149

🤖 This preview updates automatically when you update the PR.

@aldy505 aldy505 merged commit 1ca56db into master Feb 5, 2026
16 checks passed
@aldy505 aldy505 deleted the fix/ssl-cert-authority-key-identifier branch February 5, 2026 22:06
@sentry-release-bot sentry-release-bot bot mentioned this pull request Feb 19, 2026
Closed
1 task
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aldy505 aldy505 aldy505 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Self-hosted Sentry
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oioki @aldy505