Skip to content

Revert "Revert "ref: migrate to uv (#4061)""#4097

Merged
aldy505 merged 2 commits intomasterfrom
revert-4094-byk/ci/revert-uv
Dec 11, 2025
Merged

Revert "Revert "ref: migrate to uv (#4061)""#4097
aldy505 merged 2 commits intomasterfrom
revert-4094-byk/ci/revert-uv

Conversation

@aldy505
Copy link
Collaborator

@aldy505 aldy505 commented Dec 10, 2025

Reverts #4094

@aldy505 aldy505 marked this pull request as ready for review December 10, 2025 07:11
@aldy505 aldy505 requested review from BYK, Dav1dde and joshuarli December 10, 2025 07:11
@aldy505
Copy link
Collaborator Author

aldy505 commented Dec 10, 2025

@joshuarli for context, this fails on Relay: https://github.com/getsentry/relay/actions/runs/20057809029/job/57528480346

Run getsentry/action-setup-venv@0958463ee0e02b9e8aa8f8e031afae1f84b80881
  with:
    cache-dependency-path: uv.lock
    install-cmd: uv sync --frozen --active
    venv-dir: .venv
  env:
    CARGO_TERM_COLOR: always
    RELAY_CARGO_ARGS: --locked
    IS_MASTER: true
    UV_PYTHON_INSTALL_DIR: /home/runner/work/_temp/uv-python-dir
Run actions/setup-python@0a5c61591373683505ea898e09a3ea4f39ef2b9c
  with:
    python-version-file: .python-version
    check-latest: false
    token: ***
    update-environment: true
    allow-prereleases: false
  env:
    CARGO_TERM_COLOR: always
    RELAY_CARGO_ARGS: --locked
    IS_MASTER: true
    UV_PYTHON_INSTALL_DIR: /home/runner/work/_temp/uv-python-dir
Error: The specified python version file at: .python-version doesn't exist.

Since .python-version would never be read on other repo's self-hosted e2e test, I thought we just hardcode it here to 3.12. What do you think?

@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.51%. Comparing base (ce32fe9) to head (2408dcc).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4097   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files           3        3           
  Lines         207      207           
=======================================
  Hits          206      206           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joshuarli
Copy link
Member

@joshuarli for context, this fails on Relay: https://github.com/getsentry/relay/actions/runs/20057809029/job/57528480346

Run getsentry/action-setup-venv@0958463ee0e02b9e8aa8f8e031afae1f84b80881
  with:
    cache-dependency-path: uv.lock
    install-cmd: uv sync --frozen --active
    venv-dir: .venv
  env:
    CARGO_TERM_COLOR: always
    RELAY_CARGO_ARGS: --locked
    IS_MASTER: true
    UV_PYTHON_INSTALL_DIR: /home/runner/work/_temp/uv-python-dir
Run actions/setup-python@0a5c61591373683505ea898e09a3ea4f39ef2b9c
  with:
    python-version-file: .python-version
    check-latest: false
    token: ***
    update-environment: true
    allow-prereleases: false
  env:
    CARGO_TERM_COLOR: always
    RELAY_CARGO_ARGS: --locked
    IS_MASTER: true
    UV_PYTHON_INSTALL_DIR: /home/runner/work/_temp/uv-python-dir
Error: The specified python version file at: .python-version doesn't exist.

Since .python-version would never be read on other repo's self-hosted e2e test, I thought we just hardcode it here to 3.12. What do you think?

sure, do it

@aldy505 aldy505 merged commit 2d66a99 into master Dec 11, 2025
16 checks passed
@aldy505 aldy505 deleted the revert-4094-byk/ci/revert-uv branch December 11, 2025 00:08
@github-actions github-actions bot locked and limited conversation to collaborators Dec 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants