Conversation
…on for `symbolicator-cleanup` This PR depends on getsentry/symbolicator#1799 Symbolicator changed to a distroless image: getsentry/symbolicator#1791 Therefore we'll be missing lots of regular Debian distro goodies, including healthcheck and cron.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3979 +/- ##
=======================================
Coverage 99.49% 99.49%
=======================================
Files 3 3
Lines 197 197
=======================================
Hits 196 196
Misses 1 1 ☔ View full report in Codecov by Sentry. |
hubertdeng123
approved these changes
Oct 1, 2025
Member
hubertdeng123
left a comment
There was a problem hiding this comment.
approving assuming CI passes once symbolicator PR goes through
Member
|
What's the reason we are removing cron? |
Collaborator
Author
@hubertdeng123 because symbolicator is moving to distroless |
Member
|
oh right it won't be available |
1 task
Dav1dde
approved these changes
Oct 1, 2025
Co-authored-by: David Herberth <github@dav1d.de>
Dav1dde
approved these changes
Oct 1, 2025
Co-authored-by: David Herberth <github@dav1d.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR depends on getsentry/symbolicator#1799
Symbolicator changed to a distroless image: getsentry/symbolicator#1791
Therefore we'll be missing lots of regular Debian distro goodies, including healthcheck and cron.