Set minimum bash version to 4.4.0#3873
Merged
aldy505 merged 2 commits intogetsentry:masterfrom Aug 14, 2025
Merged
Conversation
aldy505
approved these changes
Aug 14, 2025
Collaborator
Author
|
So that's why I couldn't push :) you beat me to merging new commits 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3860 by failing sooner :)
There is possibly an easy fix for #3860, but honestly bash 4.2 is pretty ancient, and I think there will be other problems with that aside from #3860 problem.
Here is bash versions on debian distributions:
Debian 9 stretch has been released 2020 and it uses bash >= 4.4.
RHEL 8 has been released 2018 and it uses bash >= 4.4.
Ubuntu 18 Bionic has been released 2018 and it uses bash >= 4.4.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.