Skip to content

fix(eap): Fix dataset parameter to target spans#3866

Merged
phacops merged 1 commit intomasterfrom
pierre/eap-fix-test-to-use-proper-dataset
Aug 12, 2025
Merged

fix(eap): Fix dataset parameter to target spans#3866
phacops merged 1 commit intomasterfrom
pierre/eap-fix-test-to-use-proper-dataset

Conversation

@phacops
Copy link
Contributor

@phacops phacops commented Aug 12, 2025

We're going to need getsentry/relay#5055 in order for this to work.

@codecov
Copy link

codecov bot commented Aug 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.45%. Comparing base (d3c0ea8) to head (2a0c472).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3866   +/-   ##
=======================================
  Coverage   99.45%   99.45%           
=======================================
  Files           3        3           
  Lines         183      183           
=======================================
  Hits          182      182           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phacops phacops requested a review from aldy505 August 12, 2025 16:45
@aldy505
Copy link
Collaborator

aldy505 commented Aug 12, 2025

@phacops What about the dataset migration? Would the self-hosted users able to read their old spans/transactions data on the web UI?

@phacops
Copy link
Contributor Author

phacops commented Aug 12, 2025

@phacops What about the dataset migration? Would the self-hosted users able to read their old spans/transactions data on the web UI?

I'm working on it, it will come in a different PR. This is what needs to be done to have a proper release.

@phacops phacops enabled auto-merge (squash) August 12, 2025 19:31
@phacops phacops requested a review from hubertdeng123 August 12, 2025 19:35
@phacops phacops merged commit 8bf5663 into master Aug 12, 2025
15 of 17 checks passed
@phacops phacops deleted the pierre/eap-fix-test-to-use-proper-dataset branch August 12, 2025 19:48
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants