fix(enhancement): ensure correct ownership check before setting permissions of profiles#3855
Merged
BYK merged 1 commit intogetsentry:masterfrom Aug 6, 2025
Merged
fix(enhancement): ensure correct ownership check before setting permissions of profiles#3855BYK merged 1 commit intogetsentry:masterfrom
BYK merged 1 commit intogetsentry:masterfrom
Conversation
aldy505
approved these changes
Aug 6, 2025
…ssions of profiles
Contributor
Author
You're welcome |
Collaborator
|
This is an improvement alright, but do we have any idea why it took so long at the first place? |
Contributor
Author
|
I guess there was something in the issue #3841? I don't know |
Collaborator
Yes, I've seen that, it was taking too long to exec chown which this PR is doing as well (in case it was parent directory was not owned by vroom:vroom) Did this took too long because it was already owned by vroom:vroom ? This PR fixes this problem (if there is). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3841
Check if the parent directory of /var/vroom/sentry-profiles is already owned by vroom:vroom.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.