fix: add schedulers for generic metrics subscriptions#3847
Merged
aldy505 merged 1 commit intogetsentry:masterfrom Aug 5, 2025
Merged
fix: add schedulers for generic metrics subscriptions#3847aldy505 merged 1 commit intogetsentry:masterfrom
aldy505 merged 1 commit intogetsentry:masterfrom
Conversation
Contributor
|
It work for me, thanks! |
aldy505
approved these changes
Aug 5, 2025
1 task
Collaborator
|
Hi @mzglinski, thank you so much for taking your time to figure out that those 4 consumers are missing. I'm checking in internally with the Snuba team if this is the right way forward. |
phacops
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #3838. By analyzing the setup in Snuba devserver, I've confirmed that in the current setup, self-hosted never acts on a generic metric subscription. I cannot be certain if this is a complete solution to the problem, but I do know it fixed the metric alerts for me.
Proof:
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.