fix tests with maskAllText, add textarea to mask-text.html #97
Closed
billyvg wants to merge 3 commits intomd-mask-enhancements-1096from
Closed
fix tests with maskAllText, add textarea to mask-text.html #97billyvg wants to merge 3 commits intomd-mask-enhancements-1096from
billyvg wants to merge 3 commits intomd-mask-enhancements-1096from
Conversation
billyvg
commented
Jul 13, 2023
| maskAllInputs?: boolean | MaskInputOptions; | ||
| maskTextFn?: MaskTextFn; | ||
| maskInputFn?: MaskTextFn; | ||
| maskInputFn?: MaskInputFn; |
Member
Author
There was a problem hiding this comment.
I assume this is desired type.
Comment on lines
+366
to
+371
| exports[`integration tests [html file]: picture-with-inline-onload.html 1`] = ` | ||
| "<html xmlns=\\"http://www.w3.org/1999/xhtml\\"><head></head><body> | ||
| <img src=\\"http://localhost:3030/images/robot.png\\" alt=\\"This is a robot\\" style=\\"opacity: 1;\\" _onload=\\"this.style.opacity=1\\" /> | ||
| </body></html>" | ||
| `; | ||
|
|
| { | ||
| \\"type\\": 3, | ||
| \\"textContent\\": \\"SCRIPT_PLACEHOLDER\\", | ||
| \\"textContent\\": \\"****** **** ***********\\", |
Member
Author
There was a problem hiding this comment.
This is correct, just a div with text content
Comment on lines
-6375
to
-6389
| { | ||
| \\"type\\": 6, | ||
| \\"data\\": { | ||
| \\"plugin\\": \\"rrweb/console@1\\", | ||
| \\"payload\\": { | ||
| \\"level\\": \\"warn\\", | ||
| \\"trace\\": [ | ||
| \\"Object.get (__puppeteer_evaluation_script__:13:33)\\", | ||
| \\"isObjTooDeep (:8503:25)\\", | ||
| \\"isObjTooDeep (:8503:35)\\", | ||
| \\"shouldIgnore (:8567:31)\\", | ||
| \\"Object.<anonymous> (:8536:13)\\", | ||
| \\"stringify (:8517:19)\\", | ||
| \\":8656:47\\" | ||
| ], |
Member
Author
There was a problem hiding this comment.
console debugging that got saved to a snapshot
| { | ||
| \\"type\\": 3, | ||
| \\"textContent\\": \\"SCRIPT_PLACEHOLDER\\", | ||
| \\"textContent\\": \\"mask4\\", |
Member
Author
There was a problem hiding this comment.
Hmm this should be masked....
| \\"childNodes\\": [ | ||
| { | ||
| \\"type\\": 3, | ||
| \\"textContent\\": \\"mask5\\", |
| \\"childNodes\\": [ | ||
| { | ||
| \\"type\\": 3, | ||
| \\"textContent\\": \\"****2\\", |
Member
Author
There was a problem hiding this comment.
huh what is this 2?, oh is it only masking mask?
| \\"childNodes\\": [ | ||
| { | ||
| \\"type\\": 3, | ||
| \\"textContent\\": \\"****3\\", |
| \\"attributes\\": { | ||
| \\"type\\": \\"radio\\", | ||
| \\"name\\": \\"toggle\\", | ||
| \\"value\\": \\"on\\" |
Member
Author
There was a problem hiding this comment.
looks right, should be unmasked
…as a textContent field and can be source of bugs
016ce19 to
02ab226
Compare
ab517c5 to
0bccb5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since <textarea> has a textContent field, it can be source of bugs when used with
maskAllText.