chore: Include original rrweb and Sentry licenses#92
Merged
Conversation
include both licenses - original rrweb license - sentry license for our modifications
chadwhitacre
reviewed
Jul 6, 2023
Co-authored-by: Chad Whitacre <chad@zetaweb.com>
chadwhitacre
approved these changes
Jul 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While setting up the publishing process for our
rrwebfork, we changed theLICENSEtext (#18) to our standard MIT license. This was recently pointed out in rrweb-io#1248. While It's worth noting that our fork was also always MIT-licensed, we did changed the copyright, which incorrectly suggested that the repo's code was ours. While I'm not entirely sure what the reason for the change was back then, in hindsight this shouldn't have happened and I'm sorry for causing any confusion associated with this change.This PR adjusts the
LICENSEfile to include both, rrweb's original license as well as our license text, which is what we settled on after internal conversations (see #91 (comment)).rendered version: https://github.com/getsentry/rrweb/blob/8fdd4ba84099de6717458e2d7b2e4f610ba634ca/LICENSE