fix: Mask <option> values for selects & radio/checkbox value#75
Merged
fix: Mask <option> values for selects & radio/checkbox value#75
<option> values for selects & radio/checkbox value#75Conversation
<option> values for selects<option> values for selects & radio/checkbox value
Member
Author
|
Also made a PR upstream for this: rrweb-io#1164 |
Lms24
approved these changes
Mar 2, 2023
billyvg
approved these changes
Mar 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures we mask
<option>when selects should be masked.We mask both the
valueattribute as well as the text content of the<option>.note that due to how masking work, the replay may not look completely correct. E.g. if you have the following:
it is masked to:
since technically both options have the same "value" now, when a user selects an option it may not reflect the longer text in the select box. However, I'd say that is OK, and better than to leak the values.
In addition, this also makes sure to mask
valueof radio/checkbox inputs. Note this only affectsvalue='****'of these elements whenmaskAllInputs=true, not the content of their labels (which is masked viamaskAllText: true).Closes #74
See https://sentry-sdks.sentry.io/replays/javascript-vue-replays:7189262e513742719dbce6e5fe4556aa/?query=&referrer=%2Freplays%2F&statsPeriod=14d&yAxis=count%28%29 for a replay in action.