fix types#684
Merged
markstory merged 3 commits intogetsentry:masterfrom Oct 21, 2023
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
Merged
andersk
reviewed
Nov 13, 2023
Comment on lines
-965
to
-981
| @overload | ||
| def activate(self, func: "_F" = ...) -> "_F": | ||
| """Overload for scenario when 'responses.activate' is used.""" | ||
|
|
||
| @overload | ||
| def activate( | ||
| self, | ||
| *, | ||
| registry: Type[Any] = ..., | ||
| assert_all_requests_are_fired: bool = ..., | ||
| ) -> Callable[["_F"], "_F"]: | ||
| """Overload for scenario when | ||
| 'responses.activate(registry=, assert_all_requests_are_fired=True)' is used. | ||
|
|
||
| See https://github.com/getsentry/responses/pull/469 for more details | ||
| """ | ||
|
|
There was a problem hiding this comment.
These were important too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mypyerrors and complains thatoverloaditself hasAnyargument (which is obvious). In theory we can suppress the error with the comment, but at the same time we can just remove overloads as not required. Do not have strong opinion on this.