Skip to content

mbeliaev/req types#537

Merged
markstory merged 23 commits intogetsentry:masterfrom
beliaev-maksim:mbeliaev/req_types
May 3, 2022
Merged

mbeliaev/req types#537
markstory merged 23 commits intogetsentry:masterfrom
beliaev-maksim:mbeliaev/req_types

Conversation

@beliaev-maksim
Copy link
Copy Markdown
Collaborator

@beliaev-maksim beliaev-maksim commented Apr 8, 2022 •
edited
Loading

finalize inline types migration. Remove stub file and go with python 3 inline style

closes #552

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 8, 2022 •
edited
Loading

Codecov Report

Merging #537 (69f12e5) into master (04c9e15) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #537   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines         2534      2561   +27     
=========================================
+ Hits          2534      2561   +27
Impacted Files Coverage Δ
responses/__init__.py 100.00% <100.00%> (ø)
responses/matchers.py 100.00% <100.00%> (ø)
responses/tests/test_matchers.py 100.00% <100.00%> (ø)
responses/tests/test_responses.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04c9e15...69f12e5. Read the comment docs.

@beliaev-maksim beliaev-maksim marked this pull request as ready for review April 11, 2022 17:27
@beliaev-maksim
Copy link
Copy Markdown
Collaborator Author

beliaev-maksim commented Apr 11, 2022

@markstory
this was a real hell, still have to keep couple of type ignores.
I think we can handle ignores in another PR, if get a good idea how to fix them, for the moment I am lacking of ideas

also, can we ensure that #469 actually works and we do not get regression
I do not think we did any additional testing to check it

markstory
markstory reviewed Apr 26, 2022
View reviewed changes
Comment thread responses/__init__.py Outdated
def replace(
self,
method_or_response: Optional[Union[str, BaseResponse]] = None,
url: "Optional[Union[Pattern[str], str]]" = None,
Copy link
Copy Markdown
Member

@markstory markstory Apr 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have type aliases for this and Optional[Union[str, BaseResponse]]? They are both used a few times.

Copy link
Copy Markdown
Collaborator Author

@beliaev-maksim beliaev-maksim Apr 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea, I added them

@markstory markstory merged commit ebf6811 into getsentry:master May 3, 2022
@beliaev-maksim beliaev-maksim deleted the mbeliaev/req_types branch May 3, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markstory markstory Awaiting requested review from markstory markstory is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

py.typed file not installed by default in setup.cfg

2 participants

@beliaev-maksim @markstory