feat(ai): Mark some AI attributes as PII maybe#4860
Merged
vgrozdanic merged 4 commits intomasterfrom Jun 25, 2025
Merged
Conversation
Dav1dde
approved these changes
Jun 25, 2025
Member
Dav1dde
left a comment
There was a problem hiding this comment.
Does it make sense to also update the PII settings for already existing fields, like gen_ai.usage.output_tokens?
Member
Author
|
No need for now, want to keep PII maybe fields to minimum. 👍 |
e56ebb6 to
d7b81a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default scrubbers are too eager on these fields, rendering the experience often unusable.
We're moving the specified attributes to PII maybe which means that we'll be not scrubbing them by default, but people will be able to add it to scrubbing in settings if they wish to do so. This will be properly documented in product docs.