Skip to content

ref(feedback): update integration test and doc for #3403#3486

Merged
aliu39 merged 28 commits intomasterfrom
aliu/separate-feedback-from-attachments2
Apr 26, 2024
Merged

ref(feedback): update integration test and doc for #3403#3486
aliu39 merged 28 commits intomasterfrom
aliu/separate-feedback-from-attachments2

Conversation

@aliu39
Copy link
Copy Markdown
Member

@aliu39 aliu39 commented Apr 25, 2024

Follow-up from #3403.

#skip-changelog (doc and renaming)

@aliu39 aliu39 requested a review from a team as a code owner April 25, 2024 16:03
@aliu39
Copy link
Copy Markdown
Member Author

aliu39 commented Apr 25, 2024

Is there a way to bypass the changelog test for a small refactor like this?

Copy link
Copy Markdown
Member

@jjbayer jjbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add #skip-changelog to the PR description.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete this file.

Copy link
Copy Markdown
Contributor

@iker-barriocanal iker-barriocanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you use IDEs or tools that create specific files, you can tell git to ignore these files in all repos in your computer. You can still manually add them.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for the tip! I only knew .gitignore before this

@aliu39 aliu39 enabled auto-merge (squash) April 26, 2024 17:23
@aliu39 aliu39 merged commit 6503900 into master Apr 26, 2024
@aliu39 aliu39 deleted the aliu/separate-feedback-from-attachments2 branch April 26, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants