feat(profiles): Add a new category to count profile chunks#3303
Merged
feat(profiles): Add a new category to count profile chunks#3303
Conversation
jjbayer
approved these changes
Mar 21, 2024
Dav1dde
requested changes
Mar 21, 2024
Dav1dde
approved these changes
Mar 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can't track invalid profile chunks' duration because we might not be able to parse them and it's expensive in case they need to be rate-limited but we still want to track invalid outcomes for them.
The plan is to add this data category and record outcomes by count on top of the duration.