ref(metrics): Change bucket name to Arc<str>#3279
Merged
Conversation
jjbayer
approved these changes
Mar 18, 2024
Comment on lines
-667
to
-668
| // do this so cost tracking still works accurately. | ||
| metric_name.shrink_to_fit(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bucket name is immutable and in serveral places it is being cloned. Instead of using a String and pruning the capacity (which wasn't always done) we can instead use an immutable variant which allows for cheap clones instead.
In a follow-up we can replace metrics created by Relay with a single
Arcinstance instead of creating the mri everytime.#skip-changelog