Skip to content

docs(metrics): allow empty space character in metrics tag values#3174

Merged
viglia merged 3 commits intomasterfrom
viglia/ref/fix-metrics-doc
Feb 28, 2024
Merged

docs(metrics): allow empty space character in metrics tag values#3174
viglia merged 3 commits intomasterfrom
viglia/ref/fix-metrics-doc

Conversation

@viglia
Copy link
Copy Markdown
Contributor

@viglia viglia commented Feb 28, 2024

catching up with getsentry/develop#1171

#skip-changelog

@viglia viglia requested a review from a team as a code owner February 28, 2024 11:10
Copy link
Copy Markdown
Member

@Dav1dde Dav1dde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Relay actually accept these values?

Also since this is docs, I don't think we need a changelog entry. Can just put #skip-changelog in the PR description.

@viglia
Copy link
Copy Markdown
Contributor Author

viglia commented Feb 28, 2024

Does Relay actually accept these values?

Also since this is docs, I don't think we need a changelog entry. Can just put #skip-changelog in the PR description.

👍🏻 removed the changelog entry

yes, I quickly checked here and space character is not stripped out. Plus php is already sending tags that way.

@Dav1dde Dav1dde changed the title fix(docs): allow empty space character in metrics tag values docs(metrics): allow empty space character in metrics tag values Feb 28, 2024
@viglia viglia merged commit 3c3d33c into master Feb 28, 2024
@viglia viglia deleted the viglia/ref/fix-metrics-doc branch February 28, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants