Skip to content

fix(spans): Accept supabase without identifiers#3156

Merged
jjbayer merged 3 commits intomasterfrom
fix/supabase-from
Feb 23, 2024
Merged

fix(spans): Accept supabase without identifiers#3156
jjbayer merged 3 commits intomasterfrom
fix/supabase-from

Conversation

@jjbayer
Copy link
Copy Markdown
Member

@jjbayer jjbayer commented Feb 23, 2024

Follow-up for #3153:

  • Only accept from(...)
  • Accept table names without scrubbed identifiers.

@jjbayer jjbayer marked this pull request as ready for review February 23, 2024 13:27
@jjbayer jjbayer requested a review from a team as a code owner February 23, 2024 13:27
@jjbayer jjbayer requested a review from Dav1dde February 23, 2024 13:28
@Dav1dde
Copy link
Copy Markdown
Member

Dav1dde commented Feb 23, 2024

Oops pressed to quickly:

You can update the added code from the last PR:

 scrubbed_description.as_deref().map(|s| {
                s.trim_start_matches("from(")

to use strip_prefix and strip_suffix

@jjbayer
Copy link
Copy Markdown
Member Author

jjbayer commented Feb 23, 2024

Oops pressed to quickly:

You can update the added code from the last PR:

 scrubbed_description.as_deref().map(|s| {
                s.trim_start_matches("from(")

to use strip_prefix and strip_suffix

@Dav1dde Done!

@jjbayer jjbayer enabled auto-merge (squash) February 23, 2024 14:27
@jjbayer jjbayer merged commit 3558bba into master Feb 23, 2024
@jjbayer jjbayer deleted the fix/supabase-from branch February 23, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants