feat(profiling): Add platform field to profile frames#2629
Merged
Conversation
Merged
10 tasks
phacops
approved these changes
Oct 18, 2023
viglia
approved these changes
Oct 19, 2023
olksdr
approved these changes
Oct 19, 2023
Co-authored-by: Oleksandr <1931331+olksdr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to RN Mixed Profiles (includes Hermes JS Frames and Native iOS frames, JVM frames in the future)
feat(profiling): Add Native iOS profiles to Hermes JS profiles sentry-react-native#3349
At the moment we don't have logic to automatically recognize the frame type.
We can add a platform field based on which we can correctly symbolicate the frame
#skip-changelog