fix(internal): Corrections for DSC metrics#1491
Merged
Conversation
jjbayer
approved these changes
Sep 22, 2022
| let percentage = ((change as f64) / (total as f64)).min(1.0); | ||
| let percentage = match (change, total) { | ||
| (0, 0) => 0.0, // 0% indicates no premature changes. | ||
| _ => ((change as f64) / (total as f64)).min(1.0) * 100.0, |
Member
There was a problem hiding this comment.
nit: Doing the x100 here instead of on the presentation layer seems wrong.
Member
Author
There was a problem hiding this comment.
Agreed, though I have not found a way to do this in Datadog. If you prefer, we can also keep it between 0-1
Member
There was a problem hiding this comment.
I think it's fine - the name says "percentage", so multiplying by 100 does make the number consistent with the metric name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1466 that fixes some outlier conditions:
cc @ale-cota @AbhiPrasad
#skip-changelog