ref: Use simple modulo #shards to get the shard number#1476
Merged
Conversation
As a folllowup for #1454 we decided that we do not have to hash the org id to get the sahrd number and simple modulo #shard will be sufficient. As part of this small refactoring the `unwrap` was also removed and Result is returned instead, to propagate the error to the caller if it happens.
jjbayer
approved these changes
Sep 15, 2022
untitaker
approved these changes
Sep 15, 2022
| .last() | ||
| .map(|(_, v)| v) | ||
| .expect("At least one shard is defined"); | ||
| .ok_or(StoreError::InvalidKafkaShardRange)?; |
Member
There was a problem hiding this comment.
this is an unrelated change right? we don't think this is now more likely
Contributor
Author
There was a problem hiding this comment.
Yes, this change is unrelated. And error should not happen.
But I also wanted to remove any unwrap/expect since I already make changes to this function.
jan-auer
approved these changes
Sep 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a follow up for #1454 we decided that we do not have to hash the org id to get the shard number and simple modulo #shard will be sufficient.
As part of this small refactoring the
unwrapwas also removed and Result is returned instead, to propagate the error to the caller if it happens.#skip-changelog