fix(store): Do serialize default transaction source [INGEST-1511]#1387
Merged
fix(store): Do serialize default transaction source [INGEST-1511]#1387
Conversation
untitaker
approved these changes
Aug 8, 2022
andriisoldatenko
approved these changes
Aug 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1354, we introduced behavior that wrote back the default transaction source (
unknown) into the event during normalization.Unfortunately, since the default qualifies as
empty, this value was still not serialized into the event payload:relay/relay-general/src/protocol/transaction.rs
Lines 69 to 74 in 2d466f8
#skip-changelog because the original impl is in the same version as the fix.