feat(metrics): More SDK-based logic for transaction name extraction [INGEST-1524]#1356
Merged
jan-auer merged 4 commits intofeat/default-transaction-sourcefrom Jul 28, 2022
Merged
Conversation
jan-auer
reviewed
Jul 28, 2022
jan-auer
approved these changes
Jul 28, 2022
Instructions and example for changelogFor changes exposed to the Python package, please add an entry to For changes to the Relay server, please add an entry to
To the changelog entry, please add a link to this PR (consider a more descriptive message): - More SDK-based logic for transaction name extraction. ([#1356](https://github.com/getsentry/relay/pull/1356))If none of the above apply, you can opt out by adding #skip-changelog to the PR description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds more cases of SDK / tag combinations that should be treated as
high-cardinality transaction names. This was obtained from tests with
real-world data, indicating SDK bugs falling back to raw URLs:
sentry.python: integrations contains "django" when http.status is404
sentry.javascript.node: integrations contains "Express" whenhttp.methodis "OPTIONS"sentry.javascript.nextjs: allsentry.php.laravel: allsentry.php.symphony: allMore info on how we found problematic SDK cases can be found in the
Jira ticket. The
SDK bugs were filed separately.
Also in this PR: Add a statsd metric for the extracted transaction name.