feat(protocol): Add transaction_info to events [INGEST-1427]#1330
Merged
feat(protocol): Add transaction_info to events [INGEST-1427]#1330
Conversation
untitaker
approved these changes
Jul 1, 2022
Member
|
please also add a statsd metric or whatever else we need to be able to view aggregates of this data |
jjbayer
approved these changes
Jul 4, 2022
Member
jjbayer
left a comment
There was a problem hiding this comment.
+1 for adding a statsd metric right away.
* master: fix: Clippy lints (#1329)
a9db3b4 to
093805f
Compare
untitaker
approved these changes
Jul 4, 2022
|
|
||
| /// The unmodified transaction name as obtained by the source. | ||
| /// | ||
| /// This value will only be set if the transaction name was modified during event processing. |
Member
There was a problem hiding this comment.
actually, don't we have _meta for original data?
Member
Author
There was a problem hiding this comment.
In the DACI it was decided not to use _meta to make the information more accessible to the product.
093805f to
dab1d3e
Compare
jjbayer
reviewed
Jul 4, 2022
relay-server/src/actors/envelopes.rs
Outdated
|
|
||
| metric!( | ||
| counter(RelayCounters::EventTransactionSource) += 1, | ||
| source = &source.to_string() |
Member
There was a problem hiding this comment.
Do we want to tag this by platform and/or SDK version?
Member
Author
There was a problem hiding this comment.
This is a great suggestion, going to add this before merging.
untitaker
approved these changes
Jul 4, 2022
2ae739a to
fdc51c9
Compare
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
transaction_infoas documented in getsentry/develop#624 and adds theevent.transaction_sourcemetric to measure how often each source occurs in practice.Requires #1329