Skip to content

fix: don't deepcopy click command in prevent cli #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joseph-sentry merged 3 commits into from
Sep 18, 2025
Merged

fix: don't deepcopy click command in prevent cli #93

joseph-sentry merged 3 commits into from
Sep 18, 2025

Conversation

@joseph-sentry
Copy link
Contributor

@joseph-sentry joseph-sentry commented Sep 18, 2025

we should just redefine the command as a separate commmand because it looks like click command objects are incompatible with deepcopy, oh well.

@codecov
Copy link

codecov bot commented Sep 18, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
695 1 694 1
View the full list of 1 ❄️ flaky tests 
api.temp.calculator.test_calculator::test_divide

Flake rate in main: 99.39% (Passed 12 times, Failed 1948 times)

Stack Traces | 0.001s run time 
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@joseph-sentry joseph-sentry force-pushed the joey/fix-deepcopy branch 2 times, most recently from 0df46c7 to 9d4c3d0 Compare September 18, 2025 20:07
@joseph-sentry
fix: don't deepcopy click command in prevent cli
94302c1 
we should just redefine the command as a separate commmand because it looks like
click command objects are incompatible with deepcopy
@joseph-sentry joseph-sentry merged commit 8c57500 into main Sep 18, 2025
26 checks passed
@joseph-sentry joseph-sentry deleted the joey/fix-deepcopy branch September 18, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomasrockhu-codecov thomasrockhu-codecov thomasrockhu-codecov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joseph-sentry @thomasrockhu-codecov