Skip to content

feat: Add codecov-cli gh release publish to craft flow #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
spalmurray merged 13 commits into from
Jul 30, 2025
Merged

feat: Add codecov-cli gh release publish to craft flow #83

spalmurray merged 13 commits into from
Jul 30, 2025

Conversation

@spalmurray
Copy link
Collaborator

@spalmurray spalmurray commented Jul 29, 2025 •
edited
Loading

Doing these separately caused issues as craft was deleting the branch/references to the codecov cli assets. This pr makes the codecov-cli assets upload with the prevent assets through the craft flow.

Also adds a script to change the editable field on the codecov-cli dependency in prevent-cli, which is necessary for the pyinstaller build to work.

@spalmurray spalmurray marked this pull request as ready for review July 29, 2025 20:22
@codecov
Copy link

codecov bot commented Jul 29, 2025 •
edited
Loading

❌ 10 Tests Failed:

Tests completed Failed Passed Skipped
6890 10 6880 10
View the top 3 failed test(s) by shortest run time 
api.temp.calculator.test_calculator::test_divide
Stack Traces | 0.001s run time 
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError
api.temp.calculator.test_calculator::test_divide
Stack Traces | 0.001s run time 
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError
api.temp.calculator.test_calculator::test_divide
Stack Traces | 0.001s run time 
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

thomasrockhu-codecov
thomasrockhu-codecov reviewed Jul 30, 2025
View reviewed changes
.github/workflows/release-codecov-cli.yml
test:
runs-on: ubuntu-latest
steps:
- run: echo "hi from build and publish codecov-cli"
Copy link
Collaborator

@thomasrockhu-codecov thomasrockhu-codecov Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm

Copy link
Collaborator Author

@spalmurray spalmurray Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lolol this is so the workflow doesn't break

@spalmurray spalmurray merged commit 4f09cdb into main Jul 30, 2025
27 of 28 checks passed
@spalmurray spalmurray deleted the spalmurray/publish-codecov-cli-to-release branch July 30, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomasrockhu-codecov thomasrockhu-codecov thomasrockhu-codecov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@spalmurray @thomasrockhu-codecov