This repository was archived by the owner on Aug 14, 2024. It is now read-only.
doc(metrics): Metric tags can only have a single value#1307
Merged
Conversation
Neither Relay nor storage support multi-value tags. Fixes getsentry/relay#3691.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Dav1dde
approved these changes
Jun 11, 2024
Member
Dav1dde
left a comment
There was a problem hiding this comment.
Technically this still allows the interpretation of having two pairs (a, 1) and (a, 2) for the same metric.
Member
Author
@Dav1dde what do you suggest? |
iker-barriocanal
approved these changes
Jun 11, 2024
src/docs/sdk/metrics.mdx
Outdated
| * **Tagging:** metrics are tagged by key value pairs, where each key can have more | ||
| than one value. Both keys and values are limited to strings, but the SDK can | ||
| expose other types if it has a reasonable way to stringify these. | ||
| * **Tagging:** metrics are tagged by key value pairs. Both keys and values are limited to strings, |
Contributor
There was a problem hiding this comment.
LGTM.
re: David's suggestion, maybe the following:
Suggested change
| * **Tagging:** metrics are tagged by key value pairs. Both keys and values are limited to strings, | |
| * **Tagging:** metrics are tagged by unique key value pairs. Both keys and values are limited to strings, |
but I think it's ok to merge as-is.
Member
There was a problem hiding this comment.
(a, 1) and (a, 2) are still unique pairs.
Dav1dde
reviewed
Jun 11, 2024
Co-authored-by: David Herberth <david.herberth@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Neither Relay nor storage support multi-value tags.
Fixes getsentry/relay#3691.