Enable MinGW builds #5
Enable MinGW builds #5Swatinem merged 11 commits intogetsentry:getsentryfrom Amphaal:getsentry_mingw
Conversation
Swatinem
left a comment
There was a problem hiding this comment.
lgtm!
The only question is about upstream compatibility.
| @@ -0,0 +1,249 @@ | |||
| // Copyright 2014 The Crashpad Authors. All rights reserved. | |||
There was a problem hiding this comment.
Are these files upstream? I wonder why they are not part of our fork?
There was a problem hiding this comment.
Ah, this is a patch to the dbghelp.h header file of MinGW, which misses somes references required by crashpad. I just copy-pasted the whole file from /compat/non_win/dbghelp.h and removed the duplicated references :P
|
@Swatinem please squash-merge this when you're fine with it. Just as a word of caution, since this adds significationly more modifications, this will make it harder to track Crashpad. Without looking into the details - should these changes potentially be fixed in upstream crashpad (excluding the CMake changes, of course). |
You are right, but they might want their building process updated accordingly for testing purposes. We should definitely poke the Crashpad team at some point so they can check our work on this. |
Please do so. I merged this, to unblock further work on |
|
https://groups.google.com/a/chromium.org/forum/#!topic/crashpad-dev/Y2tt6dDNIBI here we go.
That's a great idea ! |
Requires uasm (https://github.com/Terraspace/UASM) to compile Windows ASM files, which is available through MSYS2 depos.