fix(changelog): categorize direct commits (no PR) by commit_patterns#764
Merged
fix(changelog): categorize direct commits (no PR) by commit_patterns#764
Conversation
Commits pushed directly without an associated PR were always routed to the 'Other' leftovers section, even when their title matched a category via `commit_patterns`. This was caused by an extra `|| !raw.pr` guard in `categorizeCommits()` that forced any PR-less commit into leftovers regardless of category match. Remove the guard so only unmatched commits go to leftovers. The downstream rendering already handles PR-less entries gracefully: `createPREntriesFromRaw` uses `raw.pr ?? ''` and `formatChangelogEntry` falls back to commit-hash links when `prNumber` is falsy. The version bump calculation was not affected — it tracks bump type before the leftovers check — so this is a display-only fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Commits pushed directly without an associated PR were always routed to the
Otherleftovers section, even when their title matched a category viacommit_patterns. The version bump calculation was already correct (bump type is tracked before the leftovers guard), so this was a display-only bug.Root Cause
In
categorizeCommits(), the leftovers guard had an extra|| !raw.prclause:This forced every PR-less commit into leftovers regardless of whether
matchCommitToCategory()had already found a match.Fix
Remove
|| !raw.prso only unmatched commits go to leftovers:No other changes needed —
formatChangelogEntryalready falls back to commit-hash links whenprNumberis falsy, so PR-less entries render correctly in category sections.Tests
commit_patternsInternal Changesinstead ofOther)