Merged
Conversation
silence security warning about babel regen runtime
ryan953
approved these changes
Feb 10, 2026
| "@typescript-eslint/parser": "^4.4.1", | ||
| "autoprefixer": "^10.4.8", | ||
| "babel-loader": "^8.2.5", | ||
| "babel-loader": "^10.0.0", |
There was a problem hiding this comment.
Bug: The engines field in package.json is incompatible with the new babel-loader dependency, requiring Node.js >=18.20.0 but stating >=14.0.0, which will break local builds for some developers.
Severity: MEDIUM
Suggested Fix
Update the engines.node field in package.json to ">=18.20.0" to match the minimum version required by the updated babel-loader dependency and ensure a consistent development environment.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: package.json#L69
Potential issue: The `package.json` file specifies a Node.js engine requirement of
`>=14.0.0`. However, this change upgrades the `babel-loader` dependency to version
`10.0.0`, which requires a newer Node.js version (`^18.20.0 || ^20.10.0 || >=22.0.0`).
This mismatch will cause build failures for developers running Node.js versions between
14.0.0 and 18.19.0. While CI may pass because it uses a compatible Node.js version,
local development environments that adhere to the documented engine requirement will
fail during the build step when `babel-loader` is executed.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
silence security warning about babel regen runtime
fixes https://linear.app/getsentry/issue/CORE-140