Add support for x-timed-grid#7109
Conversation
b0ebdcb to
b93e5a8
Compare
|
|
||
| // --- Default Letters --- | ||
| @Test | ||
| fun testLetters_oneWrongAnswer_summaryCorrect() { |
There was a problem hiding this comment.
I think we should not include the tests as we've (as far as know) expressed that verifying that these features continue to work will be up to people who use it (through betas etc).
UI tests are always extra work to maintain at a stability level as well as just our own test APIs evolving and having to keep these up to date.
@lognaturel let me know if my assumption around verification expectations is wrong.
There was a problem hiding this comment.
Ok I've removed the tests.
collect_app/src/main/java/org/odk/collect/android/activities/FormFillingActivity.java
Outdated
Show resolved
Hide resolved
...pp/src/main/java/org/odk/collect/android/experimental/timedgrid/CompassionTimedGridWidget.kt
Outdated
Show resolved
Hide resolved
collect_app/src/main/java/org/odk/collect/android/formentry/FormEntryMenuProvider.kt
Outdated
Show resolved
Hide resolved
47f7a12 to
ad0c8ed
Compare
ad0c8ed to
92f214d
Compare
collect_app/src/main/java/org/odk/collect/android/utilities/Appearances.kt
Outdated
Show resolved
Hide resolved
collect_app/src/main/java/org/odk/collect/android/widgets/TimedGridWidget.kt
Outdated
Show resolved
Hide resolved
1c2ea73 to
7848c43
Compare
|
I think there's a mistake in the sample form in line 15 - second select question there is Is there any validation on these parameters? |
|
It seems to be a mistake in the form, and it should be |
|
Tested with Success! Verified on a device with Android 10 Verified cases:
|
|
Tested with Success! Verified on a device with Android 16 |
Closes #6988
Why is this the best possible solution? Were any other approaches considered?
According to our discussions, I’ve pulled the implementation as-is (with a few minor adjustments). I’ve tried to move as much code as possible into a separate module (experimental) to better isolate it from the rest of the codebase.
We should decide on the next steps for this feature:
We can implement the necessary changes to make it possible to move the feature into a separate app or we can refactor and clean up the code to meet our quality standards (at least the part that we had to add in the main module).
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
This should introduce a new question type that enables timed tests and assessments. The implementation has been tested and accepted by CI, so I don’t think we need to be overly cautious about testing every possible scenario.
Do we need any specific form for testing your changes? If so, please attach one.
The form is linked in the issue.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest