Use master rather than pr build for hotfix branch#7095
Merged
grzesiek2010 merged 2 commits intogetodk:v2026.1.xfrom Feb 17, 2026
Merged
Use master rather than pr build for hotfix branch#7095grzesiek2010 merged 2 commits intogetodk:v2026.1.xfrom
master rather than pr build for hotfix branch#7095grzesiek2010 merged 2 commits intogetodk:v2026.1.xfrom
Conversation
grzesiek2010
requested changes
Feb 17, 2026
.circleci/config.yml
Outdated
| ignore: | ||
| - master | ||
| - /^v((20)[0-9]{2})\.\d+\.\d+$/ | ||
| - ^v((20)[0-9]{2})\.\d+\.\x$ |
Member
There was a problem hiding this comment.
I think the pattern ^v((20)[0-9]{2})\.\d+\.\x$ might not work as expected. \x looks like an incomplete escape sequence and doesn’t match a literal x, so this regex probably won’t match either v2026.1.1 or v2026.1.x.
It should be something like: ^v((20)[0-9]{2})\.\d+\.(\d+|x)$
Member
Author
There was a problem hiding this comment.
We only want to match the literal x here as we never create branches like v2026.1.1. You're right though that I've got a typo here with \x - it should just be x/.
grzesiek2010
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This wasn't working because the regex we were using only matches actual semvers and hour hotfix branches end with an
x.