Skip to content

Fix dark theming for InfoDialog#7061

Merged
grzesiek2010 merged 1 commit intogetodk:masterfrom
seadowg:compose-dark
Jan 30, 2026
Merged

Fix dark theming for InfoDialog#7061
grzesiek2010 merged 1 commit intogetodk:masterfrom
seadowg:compose-dark

Conversation

@seadowg
Copy link
Member

@seadowg seadowg commented Jan 30, 2026

Closes #7059

Why is this the best possible solution? Were any other approaches considered?

It turns out you need to be in a Surface for Text to use theme colors. Otherwise, LocalContentColor will still be set to Black. This feels overly complex, but my guess is you don't have to deal with this if you're building Compose code for everything and using high level helpers like Scaffold.

I've also updated our theme for the dark and light text colors and styles.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

The dialog is the only thing affected.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@seadowg seadowg marked this pull request as ready for review January 30, 2026 18:01
@grzesiek2010 grzesiek2010 merged commit aac3211 into getodk:master Jan 30, 2026
7 checks passed
@seadowg seadowg deleted the compose-dark branch January 31, 2026 10:36
@srujner
Copy link

srujner commented Feb 3, 2026

Tested with success

Verified on Android 14

Verified cases:

@WKobus
Copy link

WKobus commented Feb 3, 2026

Tested with success

Verified on Android 16

@dbemke
Copy link

dbemke commented Feb 3, 2026

Tested with success

Verified on Android 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to modify the map modal is to dark in the dark mode.

5 participants