Fix invalid polygon state issues#7060
Merged
grzesiek2010 merged 5 commits intogetodk:masterfrom Jan 30, 2026
Merged
Conversation
seadowg
commented
Jan 30, 2026
| object LiveDataExt { | ||
| fun <T, U> LiveData<T>.zip(other: LiveData<U>): LiveData<Pair<T, U>> { | ||
| return LiveDataUtils.zip(this, other) | ||
| fun <T, U> LiveData<T>.combine(other: LiveData<U>): LiveData<Pair<T, U>> { |
Member
Author
There was a problem hiding this comment.
Calling this zip was misleading as it behaves like combine and that mismatch was what ended up causing the problems in #7055.
seadowg
commented
Jan 30, 2026
| } | ||
|
|
||
| updateUi() | ||
| setChangeResult() |
Member
Author
There was a problem hiding this comment.
This was causing an infinite loop! I couldn't work out how to reproduce with the threading setup in tests.
grzesiek2010
approved these changes
Jan 30, 2026
|
Tested with success Verified on Android 16 Verified cases: -Listed issues no longer occur
|
|
Tested with success Verified on Android 14 |
|
Tested with success Verified on Android 10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7055
Closes #7054
Closes #7057
Closes #7056
This fixes issues with invalid polygon points not updating on the map properly.
Why is this the best possible solution? Were any other approaches considered?
Comments inline.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
These changes do not touch the map engines so test with one is fine. It does however end up making some changes that affect other areas of the app:
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest