Remove code causing points to be added on rotate#7049
Merged
grzesiek2010 merged 2 commits intogetodk:masterfrom Jan 23, 2026
Merged
Remove code causing points to be added on rotate#7049grzesiek2010 merged 2 commits intogetodk:masterfrom
grzesiek2010 merged 2 commits intogetodk:masterfrom
Conversation
seadowg
commented
Jan 23, 2026
| } | ||
|
|
||
| public FormEntryPage assertBackgroundLocationSnackbarShown() { | ||
| onView(withId(com.google.android.material.R.id.snackbar_text)) |
Member
Author
There was a problem hiding this comment.
This failed for me when running ./gradlew testLab
grzesiek2010
approved these changes
Jan 23, 2026
|
Tested with Success! Verified on devices with Android 10 Verified cases: |
|
Tested with success Verified on Android 16 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7048
Why is this the best possible solution? Were any other approaches considered?
This was just some leftover, untested code causing problems.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Just fixes the bug. No need to test with different maps.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest