Skip to content

Allow adding points inside shapes or on trace lines in Google Maps#7044

Merged
seadowg merged 2 commits intogetodk:masterfrom
grzesiek2010:COLLECT-7039
Jan 22, 2026
Merged

Allow adding points inside shapes or on trace lines in Google Maps#7044
seadowg merged 2 commits intogetodk:masterfrom
grzesiek2010:COLLECT-7039

Conversation

@grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented Jan 22, 2026

Closes #7039

Why is this the best possible solution? Were any other approaches considered?

It wasn’t possible to add points on trace lines in earlier versions with Google Maps, so when we created DynamicPolygonFeature for polygons, we simply copied that behavior.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

This change simply unblocks adding points inside shapes or on trace lines in Google Maps.

Do we need any specific form for testing your changes? If so, please attach one.

Any form with a geotrace/geoshape question.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@grzesiek2010 grzesiek2010 requested a review from seadowg January 22, 2026 03:15
@seadowg seadowg merged commit ac155af into getodk:master Jan 22, 2026
7 checks passed
@dbemke
Copy link

dbemke commented Jan 23, 2026

Tested with Success!

Verified on devices with Android 10

Verified cases:

@WKobus
Copy link

WKobus commented Jan 23, 2026

Tested with success

Verified on Android 16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Google maps don’t add points inside a shape or on lines on a trace

4 participants