Implement new geoshape/trace style for Google/Mapbox#7024
Merged
seadowg merged 13 commits intogetodk:masterfrom Jan 20, 2026
Merged
Implement new geoshape/trace style for Google/Mapbox#7024seadowg merged 13 commits intogetodk:masterfrom
seadowg merged 13 commits intogetodk:masterfrom
Conversation
a3c8918 to
b82eb90
Compare
6 tasks
Member
Author
|
@grzesiek2010 this looks good to me! I can't approve sadly as I'm the PR author. |
Member
Author
|
@grzesiek2010 I disabled the review requirement (and then re-enabled it) so I could merge given that you're out and all the changes were yours. |
|
Tested with Success! Verified on devices with Android 16 Verified cases:
|
|
Tested with Success! Verified on devices with Android 10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6962
Blocked by #7017Why is this the best possible solution? Were any other approaches considered?
This is a continuation of #7017.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Here, we need to perform tests similar to #7017 but using Google Maps and Mapbox.
Do we need any specific form for testing your changes? If so, please attach one.
Any form with
geotrace/geoshapequestions.Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest