Validate geopoly when moving points#7010
Merged
grzesiek2010 merged 2 commits intogetodk:masterfrom Jan 6, 2026
Merged
Conversation
grzesiek2010
approved these changes
Jan 6, 2026
|
Could you send us an apk with all map tokens? We've started testing and there are differences between Mapbox and OSM so we need to check Google Maps, too. |
Member
Author
|
@dbemke the PR is merged so you should be good to use the latest master build! |
Google maps token doesn't work on the master version |
Member
Author
Oh! I thought it did. We'll need to get that fixed. I'll send you an APK. |
|
Tested with Success! Verified on devices with Android 10 Verified cases:
|
|
Tested with Success! Verified on devices with Android 16 |
|
Tested with Success! Verified on devices with Android 10 and 12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6990
Why is this the best possible solution? Were any other approaches considered?
Nothing to discuss here really! The change ended up being very simple.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Should just add validation when dragging polygon points. It'd be worth checking this works in all map engines.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest