Fix crashes editing geopoly questions#7006
Merged
grzesiek2010 merged 13 commits intogetodk:masterfrom Jan 7, 2026
Merged
Conversation
2 tasks
This was updated for JavaRosa, but not for Collect (getodk/javarosa@b129c1d)
grzesiek2010
requested changes
Jan 7, 2026
collect_app/src/main/java/org/odk/collect/android/widgets/utilities/GeoPolyDialogFragment.kt
Show resolved
Hide resolved
collect_app/src/main/java/org/odk/collect/android/widgets/utilities/GeoPolyDialogFragment.kt
Show resolved
Hide resolved
collect_app/src/main/java/org/odk/collect/android/tasks/SaveFormToDisk.java
Outdated
Show resolved
Hide resolved
collect_app/src/main/java/org/odk/collect/android/widgets/utilities/GeoPolyDialogFragment.kt
Outdated
Show resolved
Hide resolved
collect_app/src/main/java/org/odk/collect/android/widgets/utilities/GeoPolyDialogFragment.kt
Outdated
Show resolved
Hide resolved
...ect_app/src/test/java/org/odk/collect/android/widgets/utilities/GeoPolyDialogFragmentTest.kt
Show resolved
Hide resolved
grzesiek2010
requested changes
Jan 7, 2026
...ect_app/src/test/java/org/odk/collect/android/widgets/utilities/GeoPolyDialogFragmentTest.kt
Show resolved
Hide resolved
grzesiek2010
approved these changes
Jan 7, 2026
|
Tested with Success! Verified on Android 10 Verified cases:
|
|
Tested with success Verified on Android 16 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7002
Closes #7003
Blocked by getodk/javarosa#840Why is this the best possible solution? Were any other approaches considered?
The cause of the crashes was just that the underlying types being used for geoshape/trace answers was inconsistent: sometimes it was a string (
StringData) and sometimes it was geo data (GeoShapeData/GeoTraceData). I could have updated the code to treat everything as strings, but instead I chose to use the geo specific data types throughout.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Should just fix the issues! Nothing is affected other than the geoshape/trace questions.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest