Fix issues with incremental question#6998
Conversation
90838c5 to
d9ab2ad
Compare
d9ab2ad to
72d9667
Compare
|
I just verified issues and they're fixed. |
| val geopolyChange = result.getString(GeoPolyFragment.RESULT_GEOPOLY_CHANGE) | ||
| val geopoly = result.getString(GeoPolyFragment.RESULT_GEOPOLY) | ||
| val incremental = FormEntryPromptUtils.getBindAttribute(prompt, INCREMENTAL) | ||
| val incremental = FormEntryPromptUtils.getAdditionalAttribute(prompt, INCREMENTAL) |
There was a problem hiding this comment.
Reading a bind attribute was a mistake. incremental is a body attribute (https://www.w3.org/TR/xforms20/#ui-input).
|
@dbemke is this "behaviour verified" or is there more you'd like to test? |
When it comes to issues it's verified, there are some minor issues/question which we'll file when it's merged. |
|
@dbemke I think we merge this so we can keep the fix PRs relatively small. That keeps the review noise down for @grzesiek2010. We've still got a few features (UX improvements and styling changes) to work on as well as issues, so we're not near the "final" PR yet! |
Closes #6996
Closes #6995
Closes #6992
Closes #6997
Why is this the best possible solution? Were any other approaches considered?
Not a lot to discuss here. I've just fixed the issues above as well as fixing the problem of
incrementalbeing read from the wrong place.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
The changes are pretty small - I've avoided doing too much refactoring as it's still feeling like the test coverage isn't amazing for the geo poly flow. The main thing to verify is just that the above issues have been fixed and that there isn't any new issues playing around with geo trace/shape with
incrementalboth enabled and disabled.Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest