Place buttons one below the other in the add repeat dialog#6977
Merged
seadowg merged 1 commit intogetodk:masterfrom Dec 1, 2025
Merged
Place buttons one below the other in the add repeat dialog#6977seadowg merged 1 commit intogetodk:masterfrom
seadowg merged 1 commit intogetodk:masterfrom
Conversation
seadowg
approved these changes
Dec 1, 2025
|
Tested with Success! Verified on devices with Androids: 8.1, 10 and 16 Verified cases:
Separate issue filed #6981 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6976
Why is this the best possible solution? Were any other approaches considered?
As discussed in the issue, for some translations or on smaller screens, displaying the buttons in a row, even when expanded, might not be sufficient. Changing the layout to vertical is a safer solution.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
It should only change the button layout in the dialog from horizontal to vertical.
Do we need any specific form for testing your changes? If so, please attach one.
Any form with repeats.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest