Update language and add icons to the repeat dialog#6972
Merged
seadowg merged 5 commits intogetodk:masterfrom Nov 26, 2025
Merged
Update language and add icons to the repeat dialog#6972seadowg merged 5 commits intogetodk:masterfrom
seadowg merged 5 commits intogetodk:masterfrom
Conversation
grzesiek2010
commented
Nov 20, 2025
| <item name="android:paddingTop">@dimen/margin_small</item> | ||
| <item name="android:paddingBottom">@dimen/margin_small</item> | ||
| <item name="android:textAppearance">?textAppearanceBodyMedium</item> | ||
| <item name="iconSize">24dp</item> |
Member
Author
There was a problem hiding this comment.
Different icon buttons were using different icon sizes. It wasn’t noticeable before because, even when they appeared on the same screen, they were displayed vertically. In the “add repeat” dialog, however, the buttons are placed in one row, and there the size differences became visible.
seadowg
requested changes
Nov 24, 2025
alyblenkin
approved these changes
Nov 24, 2025
Collaborator
alyblenkin
left a comment
There was a problem hiding this comment.
Looking good – the dialog is a lot more intuitive with the icons and updated copy!
I didn't think we would get to this change for a while, so this was a nice surprise.
f577e6a to
6427942
Compare
seadowg
approved these changes
Nov 26, 2025
|
Tested with success Verified on Android 16, 11 Verified cases:
|
|
Tested with success Verified on Android 10, 8.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6968
Why is this the best possible solution? Were any other approaches considered?
I considered using Jetpack Compose for the new UI, but it would be quite cumbersome since this activity doesn’t use Compose at all yet.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
We need to test the dialog displayed when adding a new repeat group for regression, not just the visual changes.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest