Skip to content

Add forum post link to Android 8+ banner#6947

Merged
grzesiek2010 merged 2 commits intogetodk:masterfrom
grzesiek2010:COLLECT-6944
Oct 31, 2025
Merged

Add forum post link to Android 8+ banner#6947
grzesiek2010 merged 2 commits intogetodk:masterfrom
grzesiek2010:COLLECT-6944

Conversation

@grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented Oct 28, 2025

Closes #6944

Why is this the best possible solution? Were any other approaches considered?

Nothing to discuss here.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

There should simply be a new Learn more button that opens the forum thread. Nothing else should be changed.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@grzesiek2010 grzesiek2010 requested a review from seadowg October 28, 2025 21:02
@grzesiek2010 grzesiek2010 marked this pull request as ready for review October 28, 2025 21:02
@grzesiek2010 grzesiek2010 merged commit accfa42 into getodk:master Oct 31, 2025
6 checks passed
@dbemke
Copy link

dbemke commented Nov 5, 2025

Tested with Success!

Verified cases:

  • banner and forum post link on Android 7.1.1
  • upgrades from Collect v 2025.3.0 with and without an added project on Android 7.1.1
  • banner in two projects on Android 7.1.1
  • upgrade from Collect v2025.3.0 on Android 10
  • no banner on Android 10, 16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add forum post link to Android 8+ banner

3 participants