Don't copy existing media files when updating media only#6946
Merged
grzesiek2010 merged 19 commits intogetodk:masterfrom Dec 2, 2025
Merged
Don't copy existing media files when updating media only#6946grzesiek2010 merged 19 commits intogetodk:masterfrom
grzesiek2010 merged 19 commits intogetodk:masterfrom
Conversation
95899e8 to
b09632e
Compare
ServerFormDetails
seadowg
commented
Oct 30, 2025
...c/main/java/org/odk/collect/android/formmanagement/matchexactly/ServerFormsSynchronizer.java
Show resolved
Hide resolved
grzesiek2010
requested changes
Nov 17, 2025
collect_app/src/main/java/org/odk/collect/android/formmanagement/ServerFormUseCases.kt
Outdated
Show resolved
Hide resolved
collect_app/src/main/java/org/odk/collect/android/formmanagement/ServerFormUseCases.kt
Show resolved
Hide resolved
collect_app/src/main/java/org/odk/collect/android/formmanagement/ServerFormUseCases.kt
Show resolved
Hide resolved
collect_app/src/main/java/org/odk/collect/android/formmanagement/ServerFormUseCases.kt
Show resolved
Hide resolved
collect_app/src/main/java/org/odk/collect/android/formmanagement/ServerFormDetails.kt
Show resolved
Hide resolved
collect_app/src/main/java/org/odk/collect/android/formmanagement/ServerFormDetails.kt
Outdated
Show resolved
Hide resolved
...c/test/java/org/odk/collect/android/formmanagement/FetchFormDetailsServerFormUseCasesTest.kt
Show resolved
Hide resolved
These test file names are pretty long, but they allow IntelliJ to navigate between the file and the test.
b09632e to
f9db6d5
Compare
6ad25aa to
493711e
Compare
grzesiek2010
approved these changes
Dec 2, 2025
|
Tested with Success! Verified on device with Android 10, 12 and 14 Verified cases:
|
|
Tested with success Verified on Android 16, 11 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6843
Why is this the best possible solution? Were any other approaches considered?
To make things (hopefully) simpler to understand in the download code, I've introduced a new
Typeenum toServerFormDetailsthat replaces the existing booleans forisNotOnDeviceandisUpdated. This allows our download code to make optimizations based on the download scenario explicitly rather than having to infer it from several pieces of information.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
There should be no change in behaviour here - the only thing that should change is the performance of updating an entity list for a form that has many media files (and none have changed).
Do we need any specific form for testing your changes? If so, please attach one.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest