Add analytics for no-buttons columns-n#6940
Merged
grzesiek2010 merged 3 commits intogetodk:v2025.3.xfrom Oct 29, 2025
Merged
Conversation
grzesiek2010
requested changes
Oct 28, 2025
collect_app/src/main/java/org/odk/collect/android/widgets/WidgetFactory.java
Outdated
Show resolved
Hide resolved
grzesiek2010
requested changes
Oct 29, 2025
| const val ADD_SHORTCUT = "AddShortcut" | ||
|
|
||
| /** | ||
| * Tracks how many forms include the `no-buttons columns-n` appearance |
grzesiek2010
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds analytics so we can get insight into how many people are currently using the "gallery" appearance for selects. This will hopefully let us make more informed decisions when discussing #6920.
Why is this the best possible solution? Were any other approaches considered?
Nothing to discuss here!
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
No testing needed.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest