Skip to content

Improve map bottom sheet#6936

Merged
grzesiek2010 merged 3 commits intogetodk:masterfrom
seadowg:map-bottom-sheet
Oct 28, 2025
Merged

Improve map bottom sheet#6936
grzesiek2010 merged 3 commits intogetodk:masterfrom
seadowg:map-bottom-sheet

Conversation

@seadowg
Copy link
Member

@seadowg seadowg commented Oct 16, 2025 •
edited
Loading

Closes #6871

Why is this the best possible solution? Were any other approaches considered?

Nothing to discuss here really!

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Just makes the changes described in the issue! Nothing other than the selection map bottom sheet should be affected.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@seadowg seadowg marked this pull request as ready for review October 16, 2025 13:10
@seadowg seadowg requested a review from grzesiek2010 October 27, 2025 11:43
@seadowg seadowg requested a review from grzesiek2010 October 27, 2025 13:52
@grzesiek2010 grzesiek2010 merged commit 5e65299 into getodk:master Oct 28, 2025
6 checks passed
@seadowg seadowg deleted the map-bottom-sheet branch October 28, 2025 16:28
@dbemke
Copy link

dbemke commented Nov 5, 2025

Does this PR influence also the font size? Can the user change the font size in the bottom sheet?

@seadowg
Copy link
Member Author

seadowg commented Nov 5, 2025 •
edited
Loading

Does this PR influence also the font size? Can the user change the font size in the bottom sheet?

No - it just increases the font size for the property labels.

@dbemke
Copy link

dbemke commented Nov 5, 2025

On the master version apk Google Maps don't work and there used to be issues with the bottom sheet in different sources of maps. Could you send us an apk with all maps tokens?

@seadowg
Copy link
Member Author

seadowg commented Nov 5, 2025

On the master version apk Google Maps don't work and there used to be issues with the bottom sheet in different sources of maps. Could you send us an apk with all maps tokens?

It shouldn't matter for this as we've only changed code internal to the bottom sheet.

@lognaturel
Copy link
Member

lognaturel commented Nov 5, 2025

It’s also in the beta which you could download from the release if it hasn’t published yet.

@dbemke dbemke mentioned this pull request Nov 6, 2025
Closed
@dbemke
Copy link

dbemke commented Nov 6, 2025

Tested with Success!

Verified on a device with Android 10

Verified cases:

  • Make bottom sheet on map more user friendly #6871 works as expected
  • map bottom sheet in entities follow-up and update form
  • upgrades with a saved instance using the bottom sheet
  • scrolling map bottom sheet
  • map bottom sheets in the form map and offline layers (on map and in settings)
  • map bottom sheet buttons and pills

@WKobus
Copy link

WKobus commented Nov 6, 2025

Tested with success

Verified on Android 16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grzesiek2010 grzesiek2010 grzesiek2010 approved these changes

Assignees

No one assigned

Labels

behavior verified

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make bottom sheet on map more user friendly

5 participants

@seadowg @dbemke @lognaturel @WKobus @grzesiek2010