Remove duplicate map points when zooming to them#6934
Remove duplicate map points when zooming to them#6934seadowg merged 2 commits intogetodk:v2025.3.xfrom
Conversation
|
@seadowg should this go to a point release? As I remember, it was placed above v2025.4 in the project board but I wanted to double-check |
|
Could you send us the apk? |
|
Now if there are 2 points which are exactly the same in OSM in the map view you can see "Choices:2 (2 shown on map)" and at the same time you can see (and tap) only one point (one point exists in the map) - is it expected? |
This should be the same in all maps right? What was the behaviour in the situation before? |
It works the same as it does in the store version. If there are the same points Google maps allow to tap "again" and it possible to select the other point, while Mapbox and OSM allow tapping/choosing just one of the points (as if the other one doesn't exist). |
Ah I see. No, the number of points should remain the same, I'd just expect that when you click on the point, you always get one and not the other. |
|
Tested with Success! Verified on a device with Android 10 Verified cases:
|
|
Tested with Success! Verified on a device with Android 16 |
Closes #6921
Why is this the best possible solution? Were any other approaches considered?
It looks like the problem is in OSM, not in our code. OSM is no longer maintained, so there’s no chance of getting a fix. That’s why I decided to handle it by removing duplicates, which are actually redundant in this case.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
We need to verify that zooming to points (in all map engines) works without regression. Nothing else should be affected.
Do we need any specific form for testing your changes? If so, please attach one.
The form mentioned in the issue.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest