Merged
Conversation
seadowg
commented
Oct 14, 2025
| ).initialize() | ||
| mapsInitializer.initialize() | ||
| JavaRosaInitializer(propertyManager, projectsDataService, entitiesRepositoryProvider, settingsProvider).initialize() | ||
| SystemThemeMismatchFixInitializer(context).initialize() |
Member
Author
There was a problem hiding this comment.
This was actually causing ANRs (Crashlytics report here). It's no longer needed now that we're always following the system theme (original PR here).
1d3de3c to
8eda25b
Compare
8eda25b to
86b3c6d
Compare
seadowg
commented
Oct 15, 2025
| ToastUtils.showShortToast(org.odk.collect.strings.R.string.form_update_succeeded) | ||
| } | ||
| } | ||
| viewModel.syncWithServer() |
grzesiek2010
approved these changes
Oct 15, 2025
Member
|
@seadowg, anything that is worth testing here? |
Member
Author
No I don't think so! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the feature flags we had in place for the removal of the themes setting and for the foreground service match exactly syncs. Both were set to
trueso I've effectively just removed dead code here.