Add experimental opt-in for entities spec v2025.1#6930
Add experimental opt-in for entities spec v2025.1#6930seadowg merged 5 commits intogetodk:masterfrom
Conversation
..._app/src/main/java/org/odk/collect/android/application/initialization/JavaRosaInitializer.kt
Outdated
Show resolved
Hide resolved
|
I'm not sure about this case. When I download forms with entities spec v 20205.1, enable spec v2025.1 in Collect settings and open one of the form, it is possible to open the form even if I disable spec v2025.1 in settings afterwards. Is it ok for the time being? Steps to reproduce:
|
|
Should forms with spec 2025.1 and the setting enabled in Collect allow creating offline entities in update forms with entities in repeats? |
Ah interesting. I guess that's because it checks when parsing so once the cached form definition is available it won't check again. I think that's fine for now.
No. We haven't implemented offline entities from repeats yet. Forms should behave as if they were using the v2024.1 spec. |
|
Tested with success Verified on Android 16 Verified cases:
|
|
Tested with success Verified on Android 10 |
Closes #6923
Why is this the best possible solution? Were any other approaches considered?
Nothing to discuss here.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
We need to just verify that forms that use entities with spec v2025.1 work when the new setting is enabled. Otherwise, there should be no change in behavior.
Do we need any specific form for testing your changes? If so, please attach one.
Forms that use entities with spec v2025.1
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest